fix(pagination): optimize OdsPagination to prevent performance and memory issue #797
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ating infinite DOM <li> components when totalPage is a big number
|
Moved to #800 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OdsPagination control suffers from rendering a lot of hidden components and using too much memory.
If totalPages is 5000 elements :
Actual code will create an array of 5000 elements and then UI will render 5000
This will significantly slow down the UI in this context (you can await more than 2 seconds before be able to click)
Worst, if you increase totalPages to 1000000, the browser will crash with OutOfMemory.
The purposed fix create only visible pages.