-
Notifications
You must be signed in to change notification settings - Fork 8
feat(combobox): implement component #785
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
var-poro
wants to merge
7
commits into
ods-react
Choose a base branch
from
feat-combobox
base: ods-react
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ec107f2
to
47fc40d
Compare
dpellier
requested changes
May 15, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From the doc:
- the font in the input is incorrect
- the outline square bottom borders stays after selection, should be round again when content is closed
- combobox root should be
inline-block
(see clearable example on the doc to see the issue) - disabled style is incorrect
- item disabled example doesn't work
- exampe "Custom Item" is the static source parameter, we can't see the function used
- it feels weird to filter only by label when we have customRenderer
- example "Form Field" should add a label (try with FormFieldLabel and see if it focus the combobox on click, otherwise use a ComboboxLabel)
- "Controlled" is KO, Dog is not selected in the combobox on initial render
- Add
!dev
tag to "Controlled" to remove it from the list of doc page
...es/ods-react/src/components/combobox/src/components/combobox-group/comboboxGroup.module.scss
Show resolved
Hide resolved
...es/ods-react/src/components/combobox/src/components/combobox-group/comboboxGroup.module.scss
Outdated
Show resolved
Hide resolved
...ds-react/src/components/combobox/src/components/combobox-content/comboboxContent.module.scss
Outdated
Show resolved
Hide resolved
packages/ods-react/src/components/combobox/src/context/combobox.ts
Outdated
Show resolved
Hide resolved
packages/ods-react/src/components/combobox/src/components/combobox-control/ComboboxControl.tsx
Outdated
Show resolved
Hide resolved
packages/ods-react/src/components/combobox/src/components/combobox-content/ComboboxContent.tsx
Outdated
Show resolved
Hide resolved
packages/ods-react/src/components/combobox/src/components/combobox-content/ComboboxContent.tsx
Outdated
Show resolved
Hide resolved
packages/storybook/stories/components/combobox/combobox.stories.tsx
Outdated
Show resolved
Hide resolved
dpellier
requested changes
May 15, 2025
packages/storybook/stories/components/combobox/documentation.mdx
Outdated
Show resolved
Hide resolved
dpellier
requested changes
May 15, 2025
packages/ods-react/src/components/combobox/src/components/combobox/Combobox.tsx
Outdated
Show resolved
Hide resolved
2f71dc2
to
96c77d3
Compare
dpellier
requested changes
May 19, 2025
packages/ods-react/src/components/combobox/src/context/useCombobox.tsx
Outdated
Show resolved
Hide resolved
packages/ods-react/src/components/combobox/src/context/useCombobox.tsx
Outdated
Show resolved
Hide resolved
packages/ods-react/src/components/combobox/src/controller/combobox.ts
Outdated
Show resolved
Hide resolved
packages/ods-react/src/components/combobox/src/components/combobox/Combobox.tsx
Outdated
Show resolved
Hide resolved
bd7ea10
to
0aae4b6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.