Skip to content

feat(combobox): implement component #785

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 7 commits into
base: ods-react
Choose a base branch
from
Draft

Conversation

var-poro
Copy link
Contributor

No description provided.

@var-poro var-poro force-pushed the feat-combobox branch 2 times, most recently from ec107f2 to 47fc40d Compare May 14, 2025 20:53
Copy link
Contributor

@dpellier dpellier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From the doc:

  • the font in the input is incorrect
  • the outline square bottom borders stays after selection, should be round again when content is closed
  • combobox root should be inline-block (see clearable example on the doc to see the issue)
  • disabled style is incorrect
  • item disabled example doesn't work
  • exampe "Custom Item" is the static source parameter, we can't see the function used
  • it feels weird to filter only by label when we have customRenderer
  • example "Form Field" should add a label (try with FormFieldLabel and see if it focus the combobox on click, otherwise use a ComboboxLabel)
  • "Controlled" is KO, Dog is not selected in the combobox on initial render
  • Add !dev tag to "Controlled" to remove it from the list of doc page

@var-poro var-poro force-pushed the feat-combobox branch 2 times, most recently from 2f71dc2 to 96c77d3 Compare May 19, 2025 07:34
@var-poro var-poro force-pushed the feat-combobox branch 3 times, most recently from bd7ea10 to 0aae4b6 Compare May 19, 2025 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants