Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Donor, Specimen, and Sample from Analysis Data Classes in SONG #869

Conversation

Azher2Ali
Copy link
Contributor

Summary:
This PR removes all references to Donor, Specimen, and Sample from the Analysis data classes in SONG. The changes focus on the following classes:

  • bio.overture.song.core.model.Analysis
  • bio.overture.song.server.model.analysis.Analysis
  • bio.overture.song.server.model.analysis.DataEntity

Details:

  • Removed all hardcoded references to donor, specimen, and sample classes or IDs representing these entities in the data models.
  • Cleaned up references in other classes that relied on these properties to ensure the code base continues to build and function correctly.
  • We have not yet removed the classes representing Donor, Specimen, and Sample entities or their corresponding repositories. That will be done in a later step once the system is stable without these entities.

@joneubank
Copy link
Contributor

Thanks for opening this. I want to keep this in a feature branch until we complete the whole epic . I'm creating a new branch feat/refactor-analysis-data-model based on develop and setting that as the base for this PR. We can merge the entire feature into develop when this is done.

@joneubank joneubank changed the base branch from develop to feat/refactor-analyis-data-model October 15, 2024 19:55
@Azher2Ali Azher2Ali merged commit a512322 into feat/refactor-analyis-data-model Oct 17, 2024
2 checks passed
@Azher2Ali Azher2Ali deleted the refactor/remove-donor-specimen-sample-from-analysis branch October 17, 2024 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants