Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding and ' at ' in line #85

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

f00b455
Copy link

@f00b455 f00b455 commented Nov 12, 2022

this fixes crash on start with following card attached:

cat /proc/asound/card1/stream0
Dell-WD15-Dock : USB Audio

Playback:
  Status: Stop
  Interface 2
    Altset 1
    Format: S24_3LE
    Channels: 2
    Endpoint: 0x07 (7 OUT) (ADAPTIVE)
    Rates: 48000
    Data packet interval: 1000 us
    Bits: 24
    Channel map: FL FR

Capture:
  Status: Running
    Interface = 1
    Altset = 1
    Packet Size = 336
    Momentary freq = 48000 Hz (0x6.0000)
  Interface 1
    Altset 1
    Format: S24_3LE
    Channels: 2
    Endpoint: 0x81 (1 IN) (ASYNC)
    Rates: 48000
    Data packet interval: 1000 us
    Bits: 24
    Channel map: FL FR

this fixes crash on start with following card attached:

```
cat /proc/asound/card1/stream0
Dell-WD15-Dock : USB Audio

Playback:
  Status: Stop
  Interface 2
    Altset 1
    Format: S24_3LE
    Channels: 2
    Endpoint: 0x07 (7 OUT) (ADAPTIVE)
    Rates: 48000
    Data packet interval: 1000 us
    Bits: 24
    Channel map: FL FR

Capture:
  Status: Running
    Interface = 1
    Altset = 1
    Packet Size = 336
    Momentary freq = 48000 Hz (0x6.0000)
  Interface 1
    Altset 1
    Format: S24_3LE
    Channels: 2
    Endpoint: 0x81 (1 IN) (ASYNC)
    Rates: 48000
    Data packet interval: 1000 us
    Bits: 24
    Channel map: FL FR
```
@ovenwerks
Copy link
Owner

@f00b455 Thank you for your contribution. I was not able to merge this directly but have added your code into my current working file for next release.
Could I get you to attach your /proc/asound/[device]/usbmixer file to a comment here? While your patch is valid to stop a crash, it leaves out information that would be useful for differentiating devices of the same type.

@f00b455
Copy link
Author

f00b455 commented Nov 14, 2022

Dell-WD15-Dock.txt

@f00b455
Copy link
Author

f00b455 commented Nov 14, 2022

@f00b455 Thank you for your contribution. I was not able to merge this directly but have added your code into my current working file for next release. Could I get you to attach your /proc/asound/[device]/usbmixer file to a comment here? While your patch is valid to stop a crash, it leaves out information that would be useful for differentiating devices of the same type.

I needed a quick fix directly ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants