Skip to content

Bump mordant to 18a5734 - #38384

Merged
alii merged 1 commit into
mainfrom
ali/bump-mordant-2
Aug 14, 2026
Merged

Bump mordant to 18a5734#38384
alii merged 1 commit into
mainfrom
ali/bump-mordant-2

Conversation

@alii

@alii alii commented Aug 14, 2026

Copy link
Copy Markdown
Member

Picks up scarletindustries/mordant#8: asymmetric_guard no longer claims calls that sit under their own conditions. The h2_frame_parser entry from #38374 goes away and nothing else changes. bun run rust:mordant is clean.

No-Verification-Needed: lint pin and baseline only
@coderabbitai

coderabbitai Bot commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: dd88a0a2-ba0a-4fd9-bc61-b25317dced78

📥 Commits

Reviewing files that changed from the base of the PR and between 6855f52 and 9dc3506.

📒 Files selected for processing (2)
  • Cargo.toml
  • mordant-baseline.toml
💤 Files with no reviewable changes (1)
  • mordant-baseline.toml

Walkthrough

Changes

Mordant lint update

Layer / File(s) Summary
Mordant revision and baseline alignment
Cargo.toml, mordant-baseline.toml
The workspace Mordant dependency uses revision 18a573447ab447acc0f52796188c601b9726b1bc. The h2_frame_parser.rs asymmetric_guard baseline entry is removed.

Possibly related PRs

  • oven-sh/bun#38320: Updates the Mordant dependency pin and removes a resolved baseline entry.
  • oven-sh/bun#38374: Updates the same Mordant pin and reverses the same baseline entry.

Suggested reviewers: robobun, jarred-sumner, cirospaciari

Merge Risk: ⚪ Minimal · up to 9dc35

This localized dependency update removes an obsolete parser baseline entry without identified product or production impact; no actionable merge-blocking risk remains beyond normal checks and review.

🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the primary change: updating the Mordant dependency revision.
Description check ✅ Passed The description explains the Mordant update, the baseline change, and verification with bun run rust:mordant.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Comment @coderabbitai help to get the list of available commands.

@claude claude Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM — routine mordant lint-pack revision bump with the corresponding baseline entry removed.

What was reviewed:

  • Confirmed the only Cargo.toml change is the dylint rev pin; no runtime dependency or profile changes.
  • Baseline edit is a single deletion (the h2_frame_parser asymmetric_guard suppression from #38374); removing a suppression fails closed if wrong — CI would flag it.
  • Follows the exact pattern documented in the Cargo.toml comment for mordant bumps.
Extended reasoning...

Overview

This PR bumps the pinned revision of the mordant dylint library in [workspace.metadata.dylint] from 4e08693 to 18a5734, and deletes one line from mordant-baseline.toml — the asymmetric_guard:src/runtime/api/bun/h2_frame_parser.rs suppression that the previous bump (#38374) had to add. The description says the upstream mordant change (scarletindustries/mordant#8) tightened asymmetric_guard so it no longer flags that site, making the baseline entry unnecessary.

Security risks

None. Mordant is a lint pack invoked by bun run rust:mordant in CI (.github/workflows/mordant.yml); it does not link into the shipped binary and has no effect on runtime behavior. The baseline file only controls which lint findings are grandfathered.

Level of scrutiny

Low. The Cargo.toml comment above the changed line explicitly documents this workflow: "bumping the rev is a PR of its own, where whatever the new revision finds gets fixed or added to mordant-baseline.toml." This PR is the mirror case — a rev bump plus removing a baseline entry that the new rev no longer emits. The immediately preceding merged commit on main (#38374) is the same shape. If the baseline deletion were wrong, or if the new mordant rev found anything else, bun run rust:mordant would fail in CI rather than silently pass.

Other factors

Two-line effective diff, no source code touched, no new suppressions added (only one removed, which is strictly a tightening). No prior reviewer comments on the timeline. The bug hunting system found nothing.

@alii
alii merged commit 01aa7cd into main Aug 14, 2026
11 checks passed
@alii
alii deleted the ali/bump-mordant-2 branch August 14, 2026 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant