Bump mordant to 18a5734 - #38384
Conversation
No-Verification-Needed: lint pin and baseline only
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (2)
💤 Files with no reviewable changes (1)
WalkthroughChangesMordant lint update
Possibly related PRs
Suggested reviewers: Merge Risk: ⚪ Minimal · up to This localized dependency update removes an obsolete parser baseline entry without identified product or production impact; no actionable merge-blocking risk remains beyond normal checks and review. 🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
Comment |
There was a problem hiding this comment.
LGTM — routine mordant lint-pack revision bump with the corresponding baseline entry removed.
What was reviewed:
- Confirmed the only Cargo.toml change is the dylint
revpin; no runtime dependency or profile changes. - Baseline edit is a single deletion (the h2_frame_parser
asymmetric_guardsuppression from #38374); removing a suppression fails closed if wrong — CI would flag it. - Follows the exact pattern documented in the Cargo.toml comment for mordant bumps.
Extended reasoning...
Overview
This PR bumps the pinned revision of the mordant dylint library in [workspace.metadata.dylint] from 4e08693 to 18a5734, and deletes one line from mordant-baseline.toml — the asymmetric_guard:src/runtime/api/bun/h2_frame_parser.rs suppression that the previous bump (#38374) had to add. The description says the upstream mordant change (scarletindustries/mordant#8) tightened asymmetric_guard so it no longer flags that site, making the baseline entry unnecessary.
Security risks
None. Mordant is a lint pack invoked by bun run rust:mordant in CI (.github/workflows/mordant.yml); it does not link into the shipped binary and has no effect on runtime behavior. The baseline file only controls which lint findings are grandfathered.
Level of scrutiny
Low. The Cargo.toml comment above the changed line explicitly documents this workflow: "bumping the rev is a PR of its own, where whatever the new revision finds gets fixed or added to mordant-baseline.toml." This PR is the mirror case — a rev bump plus removing a baseline entry that the new rev no longer emits. The immediately preceding merged commit on main (#38374) is the same shape. If the baseline deletion were wrong, or if the new mordant rev found anything else, bun run rust:mordant would fail in CI rather than silently pass.
Other factors
Two-line effective diff, no source code touched, no new suppressions added (only one removed, which is strictly a tightening). No prior reviewer comments on the timeline. The bug hunting system found nothing.
Picks up scarletindustries/mordant#8: asymmetric_guard no longer claims calls that sit under their own conditions. The h2_frame_parser entry from #38374 goes away and nothing else changes. bun run rust:mordant is clean.