Skip to content

feat: remove split attributes #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
nadine-nguyen wants to merge 29 commits into
base: master
Choose a base branch
from
Draft

feat: remove split attributes #1

nadine-nguyen wants to merge 29 commits into from

Conversation

@nadine-nguyen
Copy link
Collaborator

@nadine-nguyen nadine-nguyen commented May 13, 2021 •
edited
Loading

  • Need to rework how to determine where the operation we need to modify is

@nadine-nguyen
WIP: insert edits working, TODO: delete
630c42f
@nadine-nguyen
WIP: still working on delete operation....
7e302dd
@nadine-nguyen
WIP: fixed another edge case for deletes
c14cfbd
@nadine-nguyen
fix: passing tests now... but now looking for edge cases...
ed348b6
@nadine-nguyen
fix: accounting for several attributes that may fall into the edit range
d8194a8
@nadine-nguyen
WIP: still not passing....
91d4cee
@nadine-nguyen
WIP: refactor
cee1dcb
@nadine-nguyen
fix: adding delete implementation
0db5a80
@nadine-nguyen
chore: removed unused code & comments
ebcd0ba
@nadine-nguyen
chore: removing more unused code
7ab3437
@nadine-nguyen
refactor: also add attributes that have been replaced in attribute tr…
87c8dba 
…ansform
@nadine-nguyen
test: for compose detectionId
c368149
@nadine-nguyen
test: skipping detection attr embed-like test
043372c
@nadine-nguyen
WIP: beginnings of compose() with invalid attr removal
ccbb878
@nadine-nguyen
fix: adding compose() validation but still not passing rich-text fuzz…
0e67e69 
…er tests
@nadine-nguyen
fix: more fixes.... but still not passing
594bd60
@nadine-nguyen
fix: more fixes for compose()
ffec33d
@nadine-nguyen
test: more tests compose()
5fafe65
@nadine-nguyen
test: tests for different transform() functionality based off new com…
3135979 
…pose()
@nadine-nguyen
revert: revert transform() to original functionality, TODO: new trans…
ddd4c79 
…form() functionality
@nadine-nguyen
chore: small fixes to comments in transform-detections tests
b10d5e1
@nadine-nguyen
fix: new transform() functionality
c3f1996
@nadine-nguyen
refactor: transform() doesnt need to know about their own attributes,…
c4da5e4 
… only the other
@nadine-nguyen
fix: compose() - now doesnt minus runningCursor on delete...
5e7b3f0
@nadine-nguyen
test: more tests...
d6c400f
@nadine-nguyen
style: just renaming test variables so they make more sense
626c14b
@nadine-nguyen
test: another edge case for transform()
bef5b7a
@nadine-nguyen
fix: fixing another edge case for transform(), but found another edge…
dbf9b4d 
… case for compose()
@nadine-nguyen
fix: account for inserts being prioritised over deletes if they are a…
92c493a 
…t the same index
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@nadine-nguyen