Skip to content

Assignment-2#2

Open
ottp613 wants to merge 2 commits intomainfrom
assignment-2
Open

Assignment-2#2
ottp613 wants to merge 2 commits intomainfrom
assignment-2

Conversation

@ottp613
Copy link
Owner

@ottp613 ottp613 commented Jan 27, 2026

UofT-DSI | Production Assignment 2

What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)

responses to assignment 1

What did you learn from the changes you have made?

lots of processing, pipeline

Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?

NA

Were there any challenges? If so, what issue(s) did you face? How did you overcome it?

i dnt know the last part so leaving that as is

How were these changes tested?

local

A reference to a related issue in your repository (if applicable)

Checklist

  • I can confirm that my changes are working as intended

Copy link

@efantinatti efantinatti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ottp613,

Good work on preprocessing and pipelines. However, missing train-test split invalidates model evaluation, and SHAP analysis is completely absent. Please review cross-validation concepts and model interpretability.

Please address the missing train-test split and SHAP analysis requirements before resubmission.

Best,
@efantinatti

@ottp613
Copy link
Owner Author

ottp613 commented Feb 4, 2026

@efantinatti tried the test train, but cant get import shap to work. tried pip install shap and even after install shap into the venv i cant get import to work. Since everything else is done, leaving this assignment incomplete wont affect the whole module my score in quiz and assignment-1 should be good for a module complete right?

@efantinatti
Copy link

@efantinatti tried the test train, but cant get import shap to work. tried pip install shap and even after install shap into the venv i cant get import to work. Since everything else is done, leaving this assignment incomplete wont affect the whole module my score in quiz and assignment-1 should be good for a module complete right?

Hi @ottp613 thanks for your thorough explanation. You were marked as completed in the final standing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants