Skip to content

UofT-DSI | LCR Assignment 1 #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ottp613 wants to merge 6 commits into from
Closed

UofT-DSI | LCR Assignment 1 #1

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
2631ce5
Replace placeholder answers with code snippets
ottp613 Dec 15, 2025
ac4f1e1
Fix print statements and update comments in notebook
ottp613 Dec 15, 2025
b3af8f6
Fix formatting of wine_dfshape output in notebook
ottp613 Dec 15, 2025
9afcfa3
Refactor train_test_split for cleaner code
ottp613 Dec 15, 2025
a9c1398
Fix string formatting in print statement
ottp613 Dec 15, 2025
ede6194
Fix print statement formatting in assignment notebook
ottp613 Dec 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 26 additions & 10 deletions 02_activities/assignments/assignment_1.ipynb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@
"metadata": {},
"outputs": [],
"source": [
"# Your answer here"
"wine_dfshape[0]\n"
Copy link

@danielrazavi danielrazavi Jan 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wine_dfshape is not defined.

]
},
{
Expand All @@ -114,7 +114,7 @@
"metadata": {},
"outputs": [],
"source": [
"# Your answer here"
"wine_dfshape[1]"
Copy link

@danielrazavi danielrazavi Jan 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same issue as before, wine_dfshape is not defined so it doesn't understand what you're trying to access.

]
},
{
Expand All @@ -132,7 +132,7 @@
"metadata": {},
"outputs": [],
"source": [
"# Your answer here"
"print(wine_df['class'].dtype, wine_df['class'].unique())"
]
},
{
Expand All @@ -151,7 +151,7 @@
"metadata": {},
"outputs": [],
"source": [
"# Your answer here"
"wine_dfshape[1]-1"
]
},
{
Expand Down Expand Up @@ -204,7 +204,7 @@
"id": "403ef0bb",
"metadata": {},
"source": [
"> Your answer here..."
"> For uniform and fair comparision of data in same context"
]
},
{
Expand All @@ -220,7 +220,7 @@
"id": "fdee5a15",
"metadata": {},
"source": [
"> Your answer here..."
"> as this is the response class which we want to find"
]
},
{
Expand All @@ -236,7 +236,7 @@
"id": "f0676c21",
"metadata": {},
"source": [
"> Your answer here..."
"> seed value used so that sequence of random numbers is same each time. same seed value, guarantees the same results each time. random seed number is fine, nothing particular is needed"
]
},
{
Expand All @@ -261,7 +261,10 @@
"\n",
"# split the data into a training and testing set. hint: use train_test_split !\n",
"\n",
"# Your code here ..."
"A = predictors_standardized\n",
"B = wine_df['class']\n",
"A_train, A_test, B_train, B_test = train_test_split(A, B, test_size=0.25,stratify=wine_df['class'])\n"
"print(A_train.shape, A_test.shape)\n"
]
},
{
Expand Down Expand Up @@ -289,7 +292,14 @@
"metadata": {},
"outputs": [],
"source": [
"# Your code here..."
"from sklearn.neighbors import KNeighborsClassifier\n",
"from sklearn.model_selection import GridSearchCV\n",
"knn = KNeighborsClassifier() \n",
"param_grid = {\"n_neighbors\": list(range(1, 51))}\n",
"grid_search = GridSearchCV(knn, param_grid, cv=10, scoring='accuracy')\n",
"grid_search.fit(A_train, B_train)\n",
"best_k = grid_search.best_params_['n_neighbors']\n",
"print(f'Best k value:{best_k}')"
]
},
{
Expand All @@ -310,7 +320,13 @@
"metadata": {},
"outputs": [],
"source": [
"# Your code here..."
"from sklearn.neighbors import KNeighborsClassifier\n",
"from sklearn.metrics import accuracy_score\n",
"final_knn = KNeighborsClassifier(n_neighbors=best_k)\n",
"final_knn.fit(A_train, B_train)\n",
"B_pred = final_knn.predict(A_test)\n",
"accuracy = accuracy_score(A_test, B_pred)\n",
Copy link

@danielrazavi danielrazavi Jan 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure this is how accuracy_score is supposed to be used?

"print(f'Test Set Accuracy: {accuracy}')"
]
},
{
Expand Down