feat(cli): Allow configuring IDL JSON location in workspace config#4483
Conversation
|
@jamie-osec is attempting to deploy a commit to the Solana Foundation Team on Vercel. A member of the Team first needs to authorize it. |
acheroncrypto
left a comment
acheroncrypto
left a comment
There was a problem hiding this comment.
This seems like a reasonable feature to add. The comments are only for small issues.
There was a problem hiding this comment.
This change will be deployed immediately after the merge, which could cause issues when people try to use this feature before the next version is out. This has been a common problem. I see someone already working on v2 docs (#4460), so thoughts on versioning the docs going forward?
There was a problem hiding this comment.
Good point, we should probably figure this out before touching the docs too much
There was a problem hiding this comment.
That PR seems to update how the TS package docs work, but the issue was about the main docs site. I believe TS package docs never automatically updated on every merge anyway.
acheroncrypto
left a comment
acheroncrypto
left a comment
There was a problem hiding this comment.
Changes look great, but as noted previously in #4483 (comment) we should version the docs. Probably something like:
https://www.anchor-lang.com/docs/<TAG_OR_BRANCH>/...
It should default to the latest stable version if there is no tag or branch parameter.
Do you want to revert the docs changes until then? In any case, it probably wouldn't hurt to merge this if you intend to make a new release shortly after.
|
The move to the new organisation has broken automated deployment, and either way we should be releasing soon, so no issue merging I think. |
3 participants
Closes #3533 by clarifying the docs and allowing configuring the location of the IDL JSON as well as types.