-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds the ability to rename inference rules when Tex filtering. #106
Open
heades
wants to merge
49
commits into
ott-lang:master
Choose a base branch
from
heades:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
issues when using ott with pandoc.
Identifiers can now contain greek characters
(prevents missing JSON homs breaking the whole pp output)
- update names of relevant library modules/functions - replace embedded ocamlgraph with installed copy using ocamlfind
(in particular, curl needs to follow the github redirect)
They consist of the ott prefix concatenated with "RenameRule" followed by the name of the rule.
I was just wondering whether there has been any update on the possibility of getting this merged in? It looks like the issues discussed in #62 have been resolved, as far as I can tell. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally, Ott did not allow one to easily rename an inference rule
in Tex. For example, in an Ott specification one might define a rule
like the following:
Unfortunately, Ott does not provide any means of giving a Tex version of
the name "Fun".
Given the previous rule Ott would generate the following LaTex
(assuming no prefix was given to Ott, and that the judgment prefix is
"T_"):
We can see that the name of the rule "T_Fun" is not easily changed within LaTex.
We fix this issue by having Ott factor out the name of each rule into
a constant LaTex command that can be renewed in LaTex. Now given the
rule above Ott will generate the following:
Then to rename the rule we can simply add the following after the Ott
generated LaTex include file has been importanted:
I felt that this modification was the least problematic when it comes
to backward compatibility.