core: start separating external widget and code editor api

ossia · Feb 6, 2025 · 5a7afd0 · 5a7afd0
1 parent 537e343
commit 5a7afd0
Show file tree

Hide file tree

Showing 2 changed files with 23 additions and 6 deletions.
diff --git a/src/plugins/score-lib-process/Process/ProcessFactory.cpp b/src/plugins/score-lib-process/Process/ProcessFactory.cpp
@@ -106,11 +106,27 @@ score::ResizeableItem* LayerFactory::makeItem(
   return nullptr;
 }
 
+bool LayerFactory::hasCodeEditor(
+    const ProcessModel&, const score::DocumentContext& ctx) const noexcept
+{
+  return false;
+}
+QWidget* LayerFactory::makeCodeEditor(
+    const ProcessModel&, const score::DocumentContext& ctx, QWidget* parent) const
+{
+  return nullptr;
+}
+
 bool LayerFactory::hasExternalUI(
     const ProcessModel&, const score::DocumentContext& ctx) const noexcept
 {
   return false;
 }
+QWidget* LayerFactory::makeExternalUI(
+    const ProcessModel&, const score::DocumentContext& ctx, QWidget* parent) const
+{
+  return nullptr;
+}
 
 HeaderDelegate* LayerFactory::makeHeaderDelegate(
     const ProcessModel& model, const Process::Context& ctx, QGraphicsItem* parent) const
@@ -123,12 +139,6 @@ FooterDelegate* LayerFactory::makeFooterDelegate(
   return new DefaultFooterDelegate{model, ctx};
 }
 
-QWidget* LayerFactory::makeExternalUI(
-    const ProcessModel&, const score::DocumentContext& ctx, QWidget* parent) const
-{
-  return nullptr;
-}
-
 bool LayerFactory::matches(const ProcessModel& p) const
 {
   return matches(p.concreteKey());

diff --git a/src/plugins/score-lib-process/Process/ProcessFactory.hpp b/src/plugins/score-lib-process/Process/ProcessFactory.hpp
@@ -79,6 +79,13 @@ class SCORE_LIB_PROCESS_EXPORT LayerFactory : public score::InterfaceBase
       const Process::ProcessModel&, const Process::Context& ctx,
       QGraphicsItem* parent) const;
 
+  virtual bool hasCodeEditor(
+      const Process::ProcessModel& proc,
+      const score::DocumentContext& ctx) const noexcept;
+  virtual QWidget* makeCodeEditor(
+      const Process::ProcessModel&, const score::DocumentContext& ctx,
+      QWidget* parent) const;
+
   virtual bool hasExternalUI(
       const Process::ProcessModel& proc,
       const score::DocumentContext& ctx) const noexcept;