feat: add go struct definitions of OSV record #333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelkedar
commented
Feb 4, 2025
Signed-off-by: Michael Kedar <[email protected]>
michaelkedar
force-pushed
the
go-structs
branch
from
28b7dc0 to
7c21232
Compare
Signed-off-by: Michael Kedar <[email protected]>
Co-authored-by: Andrew Pollock <[email protected]> Signed-off-by: Michael Kedar <[email protected]>
Signed-off-by: Michael Kedar <[email protected]>
another-rex
approved these changes
Feb 5, 2025
Yeah, the custom marshal methods are just for omitting empty struct fields and making sure timestamps are in UTC - there's no customized encoding going on. |
andrewpollock
approved these changes
Feb 6, 2025
|
I can't merge this PR myself - I'm happy for this to be merged if you are. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moving the struct definitions of the OSV record from osv-scanner to this repository, since it makes more sense to live in the
osvschemamodule.I've also added the new
upstreamfield to the struct. It's probably worth having a discussion on how to make sure these structs remain in-sync with any future changes to the schema.