Skip to content

Fix compiling error on OSX #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix compiling error on OSX #26

wants to merge 1 commit into from

Conversation

homper
Copy link

@homper homper commented May 16, 2022

Mac OS linker(/usr/bin/ld) doesn't have "--build-id" option. Same as Solaris in #6. So I filtered it out in Makefile

uname -a
Darwin hompers-mbp 20.2.0 Darwin Kernel Version 20.2.0: Wed Dec  2 20:39:59 PST 2020; root:xnu-7195.60.75~1/RELEASE_X86_64 x86_64

sw_vers
ProductName:	macOS
ProductVersion:	11.1
BuildVersion:	20C69

ld --build-id
ld: unknown option: --build-id

gcc-11 -Wl,--build-id
ld: unknown option: --build-id
collect2: error: ld returned 1 exit status

clang -Wl,--build-id
ld: unknown option: --build-id
clang-13: error: linker command failed with exit code 1 (use -v to see invocation)

Checked that build in Solaris 11 still works.

@rjuju rjuju added the bug label Dec 9, 2022
rjuju
rjuju approved these changes Dec 9, 2022
View reviewed changes
Copy link
Collaborator

@rjuju rjuju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rjuju rjuju rjuju approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@homper @rjuju