feat: Support ESM and Typescript configs #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That looks awesome! The linting is failing though, are you able to look at it? |
|
Should be fixed now |
|
I will fix the new linting errors 😅 |
|
Year the rules on the repo are very strict 😅 |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Serverless currently doesn't support loading
serverless.tsESM files withexport default { }. I submitted this PR serverless/serverless#11147 a long time ago, but they didn't go further with it because ESM in Node.js was not stable back then. It is stable now, but I think they wanted to support it only in v4.Nevertheless, the original PR implemented the ESM+TS support in a hacky way with an intermediate script and a sub-process. Meanwhile I found a much better way using jiti and it is documented here: https://github.com/zirkelc/serverless-esm-ts
This PR implements it in the same way and replaces the old outdated ts-node for loading TypeScript configs.