Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent adding unused import "osmosis_std_derive::CosmwasmExt" #103

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

loloicci
Copy link

@loloicci loloicci commented Dec 11, 2023

Without this PR, transform adds import osmosis_std_derive::CosmwasmExt to all modules given to transform_module to decrease warnings in "osmosis_std".

This PR prevents adding import osmosis_std_derive::CosmwasmExt modules not using it.
Modules that do not use import osmosis_std_derive::CosmwasmExt contain only enums and do not contain structs.

note

This PR does not contain executing proto-build. This is because the latest main's (b9ce0b7) proto-build deletes some attributes and it makes an error in "osmosis-std". Deleted attributes are as follows.

@@ -924,24 +923,3 @@ pub struct Block {
     #[prost(message, optional, tag = "4")]
     pub last_commit: ::core::option::Option<Commit>,
 }
-
-#[allow(clippy::derive_partial_eq_without_eq)]
-#[derive(
-    Clone,
-    PartialEq,
-    Eq,
-    ::prost::Message,
-    ::serde::Serialize,
-    ::serde::Deserialize,
-    ::schemars::JsonSchema,
-    CosmwasmExt,
-)]
-#[proto_message(type_url = "/tendermint.types.EventDataRoundState")]
-pub struct EventDataRoundState {
-    #[prost(int64, tag = "1")]
-    pub height: i64,
-    #[prost(int32, tag = "2")]
-    pub round: i32,
-    #[prost(string, tag = "3")]
-    pub step: String,
-}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant