Involve disused and demolished power towers in French merge analysis #2440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I propose to involve disused and demolished power towers in French merge analysis as to avoid false positives.
Disused power towers are left in OSM with lifecycle prefix to avoid any further contribution since they remain visible on aerial imagery for a significant period of time.
When moved to
disused:powerordemolished:powrkey, Osmose raise new warnings as they are still in open data too.This PR will avoid such warnings to raise against disused OSM feature
https://osmose.openstreetmap.fr/fr/issue/2ff3bbd7-0265-7086-c7ce-fc27417243cb
https://www.openstreetmap.org/node/1770640476
If successful, the same behavior will be implemented on merge_power_pole analyzers.