add list of members who didn't show up #16
Conversation
app.ts
Outdated
| @@ -119,6 +119,12 @@ setInterval(() => { | |||
| }, | |||
| { merge: true } | |||
| ) | |||
| db.collection("members") | |||
| doc("sourceStatus") | |||
There was a problem hiding this comment.
Isn't this supposed to be .doc("sourceStatus") ?
Looks like there's a missing dot
There was a problem hiding this comment.
Yes , Will add that 👍
app.ts
Outdated
| const optKeyboard: telegramBot.SendMessageOptions = { | ||
| parse_mode: "Markdown", | ||
| reply_markup: { | ||
| keyboard: [[{ text: "Source Did not respond yet" }], [{ text: "Did not asked the report yet" }]] |
There was a problem hiding this comment.
Second message could be "Did not ask the source yet" for better clarity. Feel free to suggest a different sentence
app.ts
Outdated
| memberNameChatIdMap[reporterName], | ||
| `Just in case your source didn't show up, let us know.`, | ||
| optKeyboard | ||
| ) | ||
| var chatId = parseInt(memberNameChatIdMap[reporterName]) | ||
| responseCallbacks[chatId] = async response => { | ||
| var status = (response.text == "Source Did not respond yet") ? true : false |
There was a problem hiding this comment.
As I understand this, User gets a message asking whether source showed up yet or they have to contacted the source yet and after that we send a message saying "just in case source didn't show up, let us know" and we leave the bot hanging and expecting a reply until it sends a message to them again?
I was thinking that this could just be a simple question asked to the user and they could press on "yes" or "no" buttons instead of taking in a sentence input and match it verbatim with "Source Did not respond yet"
There was a problem hiding this comment.
cool, I'll change it .
| .doc("sourceStatus") | ||
| .get() | ||
| .then( query => { | ||
| query._fieldsProto[source[idx]].booleanValue |
There was a problem hiding this comment.
Could you paste a link to a document related to this function _fieldsProto?
Summary
This PR adds an enhancement which will ask the reporters on monday if their source didn't show up, in case that happens a separate list of the sources who didn't respond to their reporters will be sent on the osl-active telegram group.