Test and fix norm_equation for RelNumFieldOrder
#4282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fingolfin
commented
Nov 7, 2024
src/NumberTheory/NmbThy.jl
Outdated
| @@ -129,7 +129,7 @@ norm_equation(R::AbsNumFieldOrder, k::Base.Integer; abs::Bool = false) = norm_eq | |||
| function norm_equation_fac_elem(R::Hecke.RelNumFieldOrder{AbsSimpleNumFieldElem,Hecke.AbsSimpleNumFieldOrderFractionalIdeal}, a::AbsNumFieldOrderElem{AbsSimpleNumField,AbsSimpleNumFieldElem}) | |||
|
|
|||
| @assert Hecke.is_maximal(R) | |||
| Ka, mKa, mkK = absolute_field(Hecke.nf(R)) | |||
| Ka, mKa, mkK = Hecke.absolute_field(Hecke.nf(R)) | |||
There was a problem hiding this comment.
So this line needs to be changed further
thofma
reviewed
Nov 8, 2024
fingolfin
force-pushed
the
mh/norm_equation
branch
from
3dc010e
to
8064151
Compare
Co-authored-by: Tommy Hofmann <[email protected]>
fingolfin
force-pushed
the
mh/norm_equation
branch
from
8064151
to
a7dcf1f
Compare
fingolfin
changed the title
norm_equation for RelNumFieldOrdernorm_equation for RelNumFieldOrder
lgoettgens
reviewed
Nov 10, 2024
Co-authored-by: Lars Göttgens <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4282 +/- ##
==========================================
+ Coverage 84.49% 84.53% +0.03%
==========================================
Files 641 641
Lines 85528 85528
==========================================
+ Hits 72269 72303 +34
+ Misses 13259 13225 -34
|
fieker
approved these changes
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While looking at PR #4261 I noticed the norm equation code for
RelNumFieldOrderis untested. So I though I could just quickly add a simple test. Sadly it revealed that that code is unrunnable. I applied the first obviously necessary tweak. But it is not enough: there is noHecke.absolute_fieldmethod which takes aHecke.RelSimpleNumField{AbsSimpleNumFieldElem}(and the methods which do exist seem to have two return values, not three as the code here expects).I think it is more efficient if @fieker has a look at resolving this, he may know immediately what's going on, unlike me :-).
Oh yeah, and next up missing would be a test for
is_irreducible(a::AbsSimpleNumFieldOrderElem)but I didn't even try to go there 😂