Skip to content

Setup endpoints for EB and optimized existing code #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 21 commits into from
Dec 13, 2021
Merged

Setup endpoints for EB and optimized existing code #8

merged 21 commits into from
Dec 13, 2021

Conversation

SVijayB
Copy link
Member

@SVijayB SVijayB commented Dec 12, 2021

Description

Setup endpoints for adding, updating, deleting, and querying EB member details.

Motivation and Context

The current version of displaying EB member details in https://www.oscvitap.org/team is not dynamic.
Adding EB member details to the API helps in rendering the page easier and also adds scalability to the current website.
The API can also be used in OSC-DBot (https://github.com/SVijayB/OSC-DBot/issues/14) for getting EB details.
Apart from sending POST requests, I've set up a basic file upload form page for direct and ease of access.

This does require an update to the docs which will be worked on soon. Referencing #7.

Screenshots (if any)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.

@SVijayB SVijayB added the enhancement New feature or request label Dec 12, 2021
@SVijayB SVijayB self-assigned this Dec 12, 2021
Copy link
Contributor

@thekodeking thekodeking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything seems good, if this patch has cleared all the test trials then we can go ahead and merge it.

Copy link
Member

@dat-adi dat-adi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than a grammatical correction, everything else looks good to go, changes are neat, and are approved to go.

@dat-adi dat-adi merged commit 6641d3f into main Dec 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants