Skip to content

wizard: add Users to review step (HMS-4906) #2633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 6, 2025

Conversation

mgold1234
Copy link
Collaborator

@mgold1234 mgold1234 commented Nov 27, 2024

this commit add Users to review step - (HMS-4906)

@mgold1234 mgold1234 marked this pull request as draft November 27, 2024 12:37
Copy link
Contributor

This PR is stale because it has been open 30 days with no activity. Remove "Stale" label or comment or this will be closed in 7 days.

Copy link

codecov bot commented Jan 1, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.07%. Comparing base (5e4f20e) to head (2965335).
Report is 1 commits behind head on main.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2633      +/-   ##
==========================================
+ Coverage   85.04%   85.07%   +0.03%     
==========================================
  Files         183      183              
  Lines       20588    20635      +47     
  Branches     2000     2008       +8     
==========================================
+ Hits        17509    17556      +47     
  Misses       3057     3057              
  Partials       22       22              
Files with missing lines Coverage Δ
...ents/CreateImageWizard/steps/Review/ReviewStep.tsx 94.47% <100.00%> (+0.30%) ⬆️
...teImageWizard/steps/Review/ReviewStepTextLists.tsx 94.63% <100.00%> (+0.25%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e4f20e...2965335. Read the comment docs.

@github-actions github-actions bot removed the Stale label Jan 2, 2025
@mgold1234 mgold1234 force-pushed the add_review branch 2 times, most recently from 07923de to 4af3278 Compare January 2, 2025 09:04
@mgold1234 mgold1234 changed the title <WIP>- Add Users to review step - (HMS-4906) wizard: Add Users to review step - (HMS-4906) Jan 2, 2025
@mgold1234 mgold1234 force-pushed the add_review branch 5 times, most recently from 4ff4dd0 to a76930d Compare January 2, 2025 15:42
@mgold1234 mgold1234 marked this pull request as ready for review January 2, 2025 15:43
@mgold1234 mgold1234 requested a review from regexowl January 3, 2025 11:19
Copy link
Collaborator

@regexowl regexowl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! Added a few comments.

@mgold1234 mgold1234 requested a review from regexowl January 5, 2025 10:19
@mgold1234 mgold1234 changed the title wizard: Add Users to review step - (HMS-4906) wizard: add Users to review step (HMS-4906) Jan 5, 2025
Copy link
Collaborator

@regexowl regexowl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@regexowl regexowl enabled auto-merge (rebase) January 6, 2025 11:21
@regexowl regexowl merged commit 6a5871b into osbuild:main Jan 6, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants