<WIP>- Add Users to review step - (HMS-4906) #2633
Draft
+887
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduces the user information step with the following fields: (*) `userName` field with validation according to Red Hat guidelines: https://access.redhat.com/solutions/30164 (*) `password` field with validation using the pam_pwquality module, which enforces strict password policies for Linux systems. This module enhances security by enforcing minimum length, complexity, and avoiding weak passwords. More info: https://access.redhat.com/solutions/6979714 Validation is configured based on the requirements defined for our systems: https://github.com/osbuild/osbuild-composer/tree/main/test/data/manifests https://github.com/osbuild/images/pkg/distro/rhel/rhel10 (*) `confirm password` field that check if confirm password equal to password (*) `ssh key` field - implement the same validation as we have in edge. [x] [wip> unit tests- in progress because I want to make sure that all new fields are in a good shape.
mgold1234
force-pushed
the
add_review
branch
from
50ca10d to
0b30043
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.