Repository navigation
Fix app hang from uncached menu localization lookups - #3053
Open
sentry[bot] wants to merge 1 commit into
Open
sentry[bot] wants to merge 1 commit into
sentry[bot] wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses an app hang issue (APPLE-MACOS-31G) caused by repeated, uncached localization lookups during menu command rendering.
The
osaurusApp.bodygetter, which defines the application's menu commands, was re-evaluated frequently due to observed singletons (ThemeManager,VADService,SpeechModelManager) and@AppStoragechanges. Each re-evaluation involved numerous calls toL(), which performs a fresh bundle lookup for every string. This cumulative overhead led to main-thread stalls exceeding 3 seconds.The fix replaces all instances of
L("...")withLCached("...")for fixed string literals withinosaurusApp.swift's menu command definitions.LCached()memoizes the localized strings, ensuring that subsequent lookups for the same key are served from a cache rather than re-querying the localization bundle. This significantly reduces the CPU overhead during menu re-renders, preventing the app hang. Dynamic labels (e.g., agent names, schedule names) remain uncached asLCached()is intended for a fixed set of keys.Changes
Test Plan
Verify that the app no longer experiences hangs or significant main-thread stalls when menu commands are re-rendered frequently. Observe reduced CPU overhead during menu interactions.
Screenshots
N/A
Checklist
CONTRIBUTING.mdFixes APPLE-MACOS-31G
@sentry <feedback>: Autofix iterates on these changes@sentry stop iterating: Autofix stops iterating on this runThis PR was automatically generated by Sentry at no cost. You can adjust this setting at any time.