Repository navigation
fix file_edit dropping an explicit empty new_string - #3048
Merged
Merged
Conversation
… file_edit deletes work (#3031)
Contributor
|
This merged after the 0.25.20 tag was created, so it is not included in the 0.25.20 binary. The release workflow read the mutable draft later and accidentally listed/marked it released. I removed the incorrect public release note and restored |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #3031
file_editrejectednew_string: ""with "old_string given without new_string", even though""is the documented way to delete a matchSchemaValidator.dropEmptyOptionalStringsruns during preflight and removes optional string arguments that are empty.new_stringis optional because theeditsbatch form exists, so it was removed beforeFileEditToolever saw itnew_stringhandling insideFileEditTool, but its tests called the tool directly and never went through preflight, so the bug was never caughtpreservedEmptyStringArgumentstoOsaurusTool(default empty).ToolRegistry.preflightpasses it intocoerceArguments(preservingEmpty:)and those arguments keep their empty valuefile_editkeepsnew_string. Sandboxfile_writekeepsnew_stringandcontent, which also fixes the documentedcontent: ""truncate to an empty filepreservingEmpty, plus aFileEditBatchTestscase that runs the reporter's exact repro through preflight and then the toolChanges
Checklist
CONTRIBUTING.md