disables default feature tokio-rustls #454
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
osa1
reviewed
Oct 17, 2025
Owner
osa1
left a comment
osa1
left a comment
There was a problem hiding this comment.
This doesn't even build.. You need to bump tokio-rustls version to 0.26, and then you'll get compile erros because 0.26 has a different API, so those need to be fixed as well.
I'd fix it myself but I don't understand TLS stuff and rustls API in too much detail. This code was written by contributors.
My understanding is we want to update tokio-rustls to 0.26 and use ring for the crypto library. If someone could make a PR doing this I'd be happy to merge.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
This patch aims to
reduce build issues on different architectures, ensure compatibility with the latest TLS version, and reduce the need for unnecessary features, reducing conflicts.
There are two missing that I don't think I need to send you.
Patch 004.skip-tests-error.patch
Due to version updates, I believe it caused these errors.
Patch 006.remove-dependencies-not-debian.patch
It was because the rustc_tools_util dependency isn't in Debian yet.
I'm already adding it to Debian; as soon as it is, I'll remove it.