Added resource endpoint for limiting access to instant book interactive slide #245
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/InteractiveSlide/InstantBook.php
Outdated
| @@ -124,7 +129,7 @@ private function getToken(Tenant $tenant, InteractiveSlide $interactive): string | |||
| $configuration = $interactive->getConfiguration(); | |||
|
|
|||
| if (null === $configuration) { | |||
| throw new \Exception('InteractiveNoConfiguration'); | |||
| throw new BadRequestHttpException('Interactive no configuration'); | |||
There was a problem hiding this comment.
what does "Interactive no configuration" mean?
| @@ -75,6 +76,10 @@ public function getConfigOptions(): array | |||
| 'required' => true, | |||
| 'description' => 'The key in the KeyVault for the password of the user.', | |||
| ], | |||
| 'resourceEndpoint' => [ | |||
| 'required' => false, | |||
| 'description' => 'The key in the KeyVault for the resources endpoint. This should supply a json list of resources that can be booked. The resources should have ResourceMail and allowInstantBooking ("True"/"False") properties set.', | |||
There was a problem hiding this comment.
I don't understand this: 'The key in the KeyVault for the resources endpoint.'
There was a problem hiding this comment.
Will add a comment to the configuration section.
sinejespersen
requested changes
Jun 12, 2025
Co-authored-by: Sine Jespersen <[email protected]>
Co-authored-by: Sine Jespersen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
#244
Link to ticket
https://leantime.itkdev.dk/#/tickets/showTicket/4680
Description
Added resource endpoint for limiting access to instant book interactive slide.
See issue for further explanation.
Checklist