Add optional Argo CD directory recurse support#26
Open
felipesdacosta wants to merge 2 commits into
Open
Conversation
hypesystem
approved these changes
May 6, 2026
Contributor
hypesystem
left a comment
hypesystem
left a comment
There was a problem hiding this comment.
This looks good to me!
It needs a rebase with develop before we can merge, but otherwise I'm ready to press the button!
| - {{ . }} | ||
| {{- end }} | ||
| {{- end }} | ||
| {{- end }} No newline at end of file |
Contributor
There was a problem hiding this comment.
tiny: would like to preserve newline at end of file
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds optional support for rendering
spec.source.directory.recursein generated Argo CDApplicationresources.This allows an app to enable recursive directory discovery by setting
directoryRecurse: trueinapplications/argo-cd-resources/values.yaml. When the value is not defined, the rendered manifests remain unchanged.Changes
directoryRecursehandling in the Argo CD applications templateCHANGELOG.mdwith the new unreleased changeTesting
Tested with:
helm template argo-cd-resources applications/argo-cd-resources
Also temporarily enabled
directoryRecurse: truefordoc-ingestionand verified that it rendersdirectory.recurse: true.Related issue
Fixes #25
Reviewer
@hypesystem