-
Notifications
You must be signed in to change notification settings - Fork 280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change the prompt wait after crash approach #20245
Change the prompt wait after crash approach #20245
Conversation
Great PR! Please pay attention to the following items before merging: Files matching
This is an automatically generated QA checklist based on modified files. |
44b4810
to
3d9254d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
HanaSR test has a command for crashing the SUT. There is code after sending this command to check that the prompt is available and eventually unlock it. Fix an issue where this prompt checking break the next command sending procedure.
3d9254d
to
0df406b
Compare
HanaSR test has a command for crashing the SUT. There is code after sending this command to check that the prompt is available and eventually unlock it. Fix an issue where this prompt checking break the next command sending procedure.
HanaSR test has a command for crashing the SUT. There is code after sending this command to check that the prompt is available and eventually unlock it. Fix an issue where this prompt checking break the next command sending procedure.
HanaSR test has a command to crash the SUT to be sent through ssh to the remote SUT. There is code after sending this command to check the prompt is available and eventually unlock it.
Fix an issue where this prompt checking break the next command sending procedure.
Verification run:
sle-15-SP6-HanaSr-Aws-Byos-x86_64-Build15-SP6_2024-09-19T02:04:03Z-hanasr_aws_test_fencing_sbd ec2_r4.8xlarge
sle-15-SP6-HanaSr-Azure-Byos-x86_64-Build15-SP6_2024-09-19T02:04:03Z-hanasr_azure_test_saptune_msi az_Standard_E4s_v3
Crash command typed here at
17:31:28
Execution immediately returns from
script_run
andrun_ssh_command
. At this pointstop_hana
callswait_serial
at17:31:28
Prompt is detected in no time
17:31:28
, was not blocked.The new code from the PR sends a
ret
to get one more prompt for the nextserial_run
to checkHere the next test stage that sends the next command
And now, with the PR fix, it get is immediately