Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deployment destroy from qesap regression #20242

Merged

Conversation

mpagot
Copy link
Contributor

@mpagot mpagot commented Sep 20, 2024

Remove cluster destroy from the test modules of qesap regression: in this way all test modules can run even if there's a failure in one of them. Deployment destroy is delegated to destroy module.

This is follow-up of #20156

Related ticket: https://jira.suse.com/browse/TEAM-9654

Verification run:

Copy link
Contributor

@alvarocarvajald alvarocarvajald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but there's a typo in the comments.

# This test module does not have both
# fatal flag and qesap_test_postfail, so that in case of failure
# the next test_ module is executed too.
# Deployment destroy is delgated to the destroy test module
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/delgated/delegated/

# This test module does not have both
# fatal flag and qesap_test_postfail, so that in case of failure
# the next test_ module is executed too.
# Deployment destroy is delgated to the destroy test module
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/delgated/delegated/

# This test module does not have both
# fatal flag and qesap_test_postfail, so that in case of failure
# the next test_ module is executed too.
# Deployment destroy is delgated to the destroy test module
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/delgated/delegated/

# This test module does not have both
# fatal flag and qesap_test_postfail, so that in case of failure
# the next test_ module is executed too.
# Deployment destroy is delgated to the destroy test module
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/delgated/delegated/

Copy link
Contributor

@lpalovsky lpalovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Remove cluster destroy from the test modules of qesap regression:
in this way all thest modules can run even if there's a failure in one
of them. Deployment destroy is delegated to destroy module.
@mpagot mpagot force-pushed the qesap_regression_test_split_fatal_flag branch from 9d6b0dd to b75d843 Compare September 27, 2024 12:39
@mpagot mpagot enabled auto-merge (squash) September 27, 2024 12:41
@mpagot mpagot merged commit fde58ea into os-autoinst:master Sep 27, 2024
10 checks passed
feri pushed a commit to feri/os-autoinst-distri-opensuse that referenced this pull request Oct 30, 2024
Remove cluster destroy from the test modules of qesap regression:
in this way all thest modules can run even if there's a failure in one
of them. Deployment destroy is delegated to destroy module.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants