-
Notifications
You must be signed in to change notification settings - Fork 280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove deployment destroy from qesap regression #20242
Remove deployment destroy from qesap regression #20242
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but there's a typo in the comments.
# This test module does not have both | ||
# fatal flag and qesap_test_postfail, so that in case of failure | ||
# the next test_ module is executed too. | ||
# Deployment destroy is delgated to the destroy test module |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/delgated/delegated/
# This test module does not have both | ||
# fatal flag and qesap_test_postfail, so that in case of failure | ||
# the next test_ module is executed too. | ||
# Deployment destroy is delgated to the destroy test module |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/delgated/delegated/
# This test module does not have both | ||
# fatal flag and qesap_test_postfail, so that in case of failure | ||
# the next test_ module is executed too. | ||
# Deployment destroy is delgated to the destroy test module |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/delgated/delegated/
# This test module does not have both | ||
# fatal flag and qesap_test_postfail, so that in case of failure | ||
# the next test_ module is executed too. | ||
# Deployment destroy is delgated to the destroy test module |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/delgated/delegated/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Remove cluster destroy from the test modules of qesap regression: in this way all thest modules can run even if there's a failure in one of them. Deployment destroy is delegated to destroy module.
9d6b0dd
to
b75d843
Compare
Remove cluster destroy from the test modules of qesap regression: in this way all thest modules can run even if there's a failure in one of them. Deployment destroy is delegated to destroy module.
Remove cluster destroy from the test modules of qesap regression: in this way all test modules can run even if there's a failure in one of them. Deployment destroy is delegated to destroy module.
This is follow-up of #20156
Related ticket: https://jira.suse.com/browse/TEAM-9654
Verification run: