Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create agama auto-installation selecting gnome pattern #20240

Merged
merged 1 commit into from
Oct 7, 2024

Conversation

hjluo
Copy link
Contributor

@hjluo hjluo commented Sep 20, 2024

Create agama auto-installation selecting gnome pattern

@jknphy jknphy changed the title Create agama auto-installation selecting gnome pattern WIP: Create agama auto-installation selecting gnome pattern Sep 20, 2024
@jknphy
Copy link
Contributor

jknphy commented Sep 20, 2024

Please, do not forget to set up WIP in your PR and label it.

@jknphy jknphy added the qe-yam label Sep 20, 2024
@hjluo hjluo force-pushed the agama_gnome_auto branch 13 times, most recently from 974eb42 to 39708b7 Compare September 27, 2024 03:47
@hjluo hjluo changed the title WIP: Create agama auto-installation selecting gnome pattern Create agama auto-installation selecting gnome pattern Sep 30, 2024
@jknphy
Copy link
Contributor

jknphy commented Sep 30, 2024

there are a lot of verification in your links above, could you filter the one related with this ticket or comment about the failures?

@hjluo
Copy link
Contributor Author

hjluo commented Sep 30, 2024

there are a lot of verification in your links above, could you filter the one related with this ticket or comment about the failures?

Done && thank you.

@jknphy
Copy link
Contributor

jknphy commented Sep 30, 2024

why all of them are failing, could you include your conclusion here?

@hjluo
Copy link
Contributor Author

hjluo commented Sep 30, 2024

why all of them are failing, could you include your conclusion here?

cause they are hang there forever as we discussed last week 😄

@jknphy
Copy link
Contributor

jknphy commented Oct 7, 2024

I suspect it is connected with:
https://github.com/os-autoinst/os-autoinst-distri-opensuse/blob/master/tests/installation/await_install.pm#L120-L124
we cannot just wait for the needle to appear.
In this case the way to investigate this kind of failures is to check how is done in other products.

Let's do the following:

  • Merge this PR
  • Setup the test suite in the job group (failing on that, it is ok)
  • Try to change that part of the code to have a "active wait".

@jknphy jknphy merged commit 732f9ee into os-autoinst:master Oct 7, 2024
10 checks passed
@hjluo
Copy link
Contributor Author

hjluo commented Oct 8, 2024

I suspect it is connected with: master/tests/installation/await_install.pm#L120-L124 we cannot just wait for the needle to appear. In this case the way to investigate this kind of failures is to check how is done in other products.

Let's do the following:

  • Merge this PR
  • Setup the test suite in the job group (failing on that, it is ok)
  • Try to change that part of the code to have a "active wait".

OK, I'd add the tests and try to change that code to see if it works. Thanks.
PS: it's PASSED after triggering. https://openqa.opensuse.org/tests/4542435

@jknphy
Copy link
Contributor

jknphy commented Oct 8, 2024

I suspect it is connected with: master/tests/installation/await_install.pm#L120-L124 we cannot just wait for the needle to appear. In this case the way to investigate this kind of failures is to check how is done in other products.
Let's do the following:

  • Merge this PR
  • Setup the test suite in the job group (failing on that, it is ok)
  • Try to change that part of the code to have a "active wait".

OK, I'd add the tests and try to change that code to see if it works. Thanks. PS: it's PASSED after triggering. https://openqa.opensuse.org/tests/4542435

but that job has too much RAM, 4GB should be enough. When you do the setup do all with default values.

@hjluo
Copy link
Contributor Author

hjluo commented Oct 8, 2024

I suspect it is connected with: master/tests/installation/await_install.pm#L120-L124 we cannot just wait for the needle to appear. In this case the way to investigate this kind of failures is to check how is done in other products.
Let's do the following:

  • Merge this PR
  • Setup the test suite in the job group (failing on that, it is ok)
  • Try to change that part of the code to have a "active wait".

OK, I'd add the tests and try to change that code to see if it works. Thanks. PS: it's PASSED after triggering. openqa.opensuse.org/tests/4542435

but that job has too much RAM, 4GB should be enough. When you do the setup do all with default values.

now all with 4G RAM with mouse moving, all 20 cases passed.

@jknphy
Copy link
Contributor

jknphy commented Oct 8, 2024

I suspect it is connected with: master/tests/installation/await_install.pm#L120-L124 we cannot just wait for the needle to appear. In this case the way to investigate this kind of failures is to check how is done in other products.
Let's do the following:

  • Merge this PR
  • Setup the test suite in the job group (failing on that, it is ok)
  • Try to change that part of the code to have a "active wait".

OK, I'd add the tests and try to change that code to see if it works. Thanks. PS: it's PASSED after triggering. openqa.opensuse.org/tests/4542435

but that job has too much RAM, 4GB should be enough. When you do the setup do all with default values.

now all with 4G RAM with mouse moving, all 20 cases passed.

but they pass without the new code for the mouse moving and 4G? (I guess not, asking just in case was something sporadic you found)

Yes, all passed with 4G RAM and with moving mouse, you can check out this PR #20350 for a detailed information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants