Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup cluster configuration #20219

Merged
merged 1 commit into from
Sep 26, 2024
Merged

Conversation

Amrysliu
Copy link
Contributor

@Amrysliu Amrysliu commented Sep 18, 2024

  1. From 15-SP4 to 15-SP7, use 'promoted' and 'unpromoted'.
  2. For 15-SP3, 15-SP2 and 12-SP5, use 'Master' because these version
    don't support 'promoted' role
  3. Uniform the resource name in hana_cluster and angi_hana_cluster
    configuratoin files for 15-SP4~15-SP7.

Related: https://jira.suse.com/browse/TEAM-9635

VRs:
15-SP7: https://openqa.suse.de/tests/15486508# (softfail)
15-SP6: https://openqa.suse.de/tests/15517245# (Softfail)
15-SP5: https://openqa.suse.de/tests/15485544# (Softfail)
15-SP4: https://openqa.suse.de/tests/15485537# (Passed)
15-SP3: https://openqa.suse.de/tests/15517248# (Passed)
15-SP2: https://openqa.suse.de/tests/15486505# (Passed)
12-SP5: https://openqa.suse.de/tests/15485651# (Passed)

Angi VR:
15-SP6: https://openqa.suse.de/tests/15486526# (Softfail)
15-SP7: https://openqa.suse.de/tests/15517244# (Softfail)

Copy link

Great PR! Please pay attention to the following items before merging:

Files matching lib/**.pm:

  • Consider adding or extending unit tests in t/

This is an automatically generated QA checklist based on modified files.

@Amrysliu Amrysliu changed the title Cleanup cluster configuration WIP: Cleanup cluster configuration Sep 18, 2024
@Amrysliu Amrysliu force-pushed the jsc_9635 branch 16 times, most recently from 23999af to 815156c Compare September 22, 2024 13:42
@Amrysliu Amrysliu changed the title WIP: Cleanup cluster configuration Cleanup cluster configuration Sep 23, 2024
@Amrysliu Amrysliu marked this pull request as ready for review September 23, 2024 12:24
Copy link
Contributor

@mpagot mpagot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@BillAnastasiadis BillAnastasiadis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

tests/sles4sap/hana_cluster.pm Outdated Show resolved Hide resolved
lib/sles4sap.pm Outdated Show resolved Hide resolved
@Amrysliu Amrysliu force-pushed the jsc_9635 branch 2 times, most recently from 2b089a4 to 60be14c Compare September 24, 2024 03:45
Copy link
Contributor

@mpagot mpagot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@alvarocarvajald alvarocarvajald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

1. From 15-SP4 to 15-SP7, use 'promoted' and 'unpromoted'.
2. For 15-SP3, 15-SP2 and 12-SP5, use 'Master' because these version
don't support 'promoted' role
3. Uniform the resource name in hana_cluster and angi_hana_cluster
configuratoin files for 15-SP4~15-SP7.

Related: https://jira.suse.com/browse/TEAM-9635
Copy link
Contributor

@lilyeyes lilyeyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally LGTM and merged.

@lilyeyes lilyeyes merged commit 4f07d49 into os-autoinst:master Sep 26, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants