-
Notifications
You must be signed in to change notification settings - Fork 280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup cluster configuration #20219
Conversation
Great PR! Please pay attention to the following items before merging: Files matching
This is an automatically generated QA checklist based on modified files. |
23999af
to
815156c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
2b089a4
to
60be14c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
1. From 15-SP4 to 15-SP7, use 'promoted' and 'unpromoted'. 2. For 15-SP3, 15-SP2 and 12-SP5, use 'Master' because these version don't support 'promoted' role 3. Uniform the resource name in hana_cluster and angi_hana_cluster configuratoin files for 15-SP4~15-SP7. Related: https://jira.suse.com/browse/TEAM-9635
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally LGTM and merged.
don't support 'promoted' role
configuratoin files for 15-SP4~15-SP7.
Related: https://jira.suse.com/browse/TEAM-9635
VRs:
15-SP7: https://openqa.suse.de/tests/15486508# (softfail)
15-SP6: https://openqa.suse.de/tests/15517245# (Softfail)
15-SP5: https://openqa.suse.de/tests/15485544# (Softfail)
15-SP4: https://openqa.suse.de/tests/15485537# (Passed)
15-SP3: https://openqa.suse.de/tests/15517248# (Passed)
15-SP2: https://openqa.suse.de/tests/15486505# (Passed)
12-SP5: https://openqa.suse.de/tests/15485651# (Passed)
Angi VR:
15-SP6: https://openqa.suse.de/tests/15486526# (Softfail)
15-SP7: https://openqa.suse.de/tests/15517244# (Softfail)