Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not run the same thing again in second firstrun wizard #20212

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Do not run the same thing again in second firstrun wizard #20212

wants to merge 1 commit into from

Conversation

rfan1
Copy link
Contributor

@rfan1 rfan1 commented Sep 18, 2024

@rfan1 rfan1 requested a review from Zaoliang September 18, 2024 06:24
@rfan1 rfan1 requested review from jlausuch and Vogtinator and removed request for mloviska and ricardobranco777 September 18, 2024 06:24
@rfan1 rfan1 added the qe-core Tag used to filter PR's created by QE-Core's members or are assigned to them label Sep 18, 2024
Vogtinator
Vogtinator requested changes Sep 18, 2024
View reviewed changes
Copy link
Member

@Vogtinator Vogtinator left a comment •
edited by rfan1
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO that's the wrong approach.

If it's not possible to fix the testing to avoid running the firstboot wizard twice, it should be made much more explicit which "stage" it is running instead of just doing the same things twice.

tests/jeos/firstrun.pm Outdated Show resolved Hide resolved
tests/jeos/firstrun.pm Outdated Show resolved Hide resolved
@rfan1 rfan1 force-pushed the jeos_user branch 5 times, most recently from f73283c to a46883a Compare September 18, 2024 08:52
@rfan1
Copy link
Contributor Author

rfan1 commented Sep 19, 2024

IMO that's the wrong approach.

If it's not possible to fix the testing to avoid running the firstboot wizard twice, it should be made much more explicit which "stage" it is running instead of just doing the same things twice.

Added a setting then.

@rfan1 rfan1 changed the title Do not create user if exists Do not run the same thing again in second firstrun wizard Sep 19, 2024
@jlausuch
Copy link
Contributor

Can't we just use EXCLUDE_MODULES=firstrun in the children jobs?

jlausuch
jlausuch requested changes Sep 20, 2024
View reviewed changes
Copy link
Contributor

@jlausuch jlausuch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest fixing the schedule so that the module is not executed on the children.

@rfan1
Copy link
Contributor Author

rfan1 commented Sep 20, 2024

Can't we just use EXCLUDE_MODULES=firstrun in the children jobs?

I tried, but seems some key steps are missing to run next modules

@Vogtinator
Copy link
Member

Can't we just use EXCLUDE_MODULES=firstrun in the children jobs?

Technically yes - but IMO it makes sense to test jeos-firstboot on the actual target hardware.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlausuch jlausuch jlausuch requested changes

@Zaoliang Zaoliang Awaiting requested review from Zaoliang

@Vogtinator Vogtinator Awaiting requested review from Vogtinator

Assignees
No one assigned
Labels
qe-core Tag used to filter PR's created by QE-Core's members or are assigned to them
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rfan1 @jlausuch @Vogtinator