Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add exponential backoff for network-related calls #139

Merged
merged 1 commit into from
Aug 9, 2023

Conversation

Martchus
Copy link
Contributor

@Martchus
Copy link
Contributor Author

I've tested this locally with some dummy command that would fail. Note that the short form (e.g. -es 30 instead of -e -s 30) does not work:

$ retry -es 3 -- bash -c 'echo foo && exit 1'
/usr/bin/retry: Zeile 38: 3: Kommando nicht gefunden.
Retrying up to 3 more times after sleeping 3s …
/usr/bin/retry: Zeile 38: 3: Kommando nicht gefunden.
Retrying up to 2 more times after sleeping 0s …
/usr/bin/retry: Zeile 38: 3: Kommando nicht gefunden.
Retrying up to 1 more times after sleeping 0s …
/usr/bin/retry: Zeile 38: 3: Kommando nicht gefunden.

Maybe that's something we want to fix within the retry script?

@mergify
Copy link
Contributor

mergify bot commented Aug 7, 2023

This pull request is now in conflicts. Could you fix it? 🙏

@perlpunk
Copy link
Contributor

perlpunk commented Aug 8, 2023

https://openqa.opensuse.org/tests/3492023#step/test_distribution/3 (problem with Test::Assert) will be fixed soon, see https://bugzilla.opensuse.org/show_bug.cgi?id=1214057
https://openqa.opensuse.org/tests/3492019#step/openqa_webui/13 (problem with Class::Accessor) - I'll have a look

edit: tracked here now: https://progress.opensuse.org/issues/133979

@mergify mergify bot merged commit 27634fe into os-autoinst:master Aug 9, 2023
5 checks passed
@Martchus Martchus deleted the backoff branch August 9, 2023 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants