Fixes for Leap 16 #294
Closed
Fixes for Leap 16 #294
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add MIRROR variables to openqa call. - Remove SLE from REPO variable name
andrii-suse
force-pushed
the
leap16_fix_mirror_and_repovar
branch
from
9d26fcf to
52d2274
Compare
|
Wow @andrii-suse. Many thanks! |
foursixnine
reviewed
May 14, 2025
| REPO_0=Leap-16.0-aarch64-ppc64le-s390x-x86_64-Build1.3 \ | ||
| REPO_SLE_LEAP_16_0_AARCH64_PPC64LE_S390X_X86_64=Leap-16.0-aarch64-ppc64le-s390x-x86_64-Build1.3 \ | ||
| REPO_LEAP_16_0_AARCH64_PPC64LE_S390X_X86_64=Leap-16.0-aarch64-ppc64le-s390x-x86_64-Build1.3 \ |
There was a problem hiding this comment.
In this case, we might want to have a different name for this repo (or have it duplicated to... i.e LEAP_REPO) would that be possible? See where its used at:
There was a problem hiding this comment.
so it is basically exactly how it is written in xml, which is exactly how it is configured in OBS. Do we really need another mapping from there to some custom name? Maybe rename it in OBS if it is too ugly?
There was a problem hiding this comment.
Quoting from our conversation
we should aim to have REPO_OSS or maybe REPO_LEAP_OSS (because the folder is 000productcompose:leap_oss)
Martchus
approved these changes
May 16, 2025
|
Deprecated by changes in #295 , (still needs another PR for mirrors variables) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@foursixnine