WIP Evaluate viability of using HTMX #5913
Conversation
r-richardson
force-pushed
the
research_htmx_viability
branch
from
b711a3f
to
b10ecde
Compare
r-richardson
force-pushed
the
research_htmx_viability
branch
from
b10ecde
to
e7e17e8
Compare
| @@ -164,6 +164,9 @@ | |||
| ! job_next_previous.js | |||
| < javascripts/job_next_previous.js | |||
|
|
|||
| ! htmx.js | |||
| < ../node_modules/htmx.org/dist/htmx.js | |||
There was a problem hiding this comment.
What's the size of that file?
There was a problem hiding this comment.
160K ./htmx.js
52K ./htmx.min.js
16K ./htmx.min.js.gz
| hx-delete="<%= url_for($delete_action => ($context->{type}.'_id' => $context->{id}, comment_id => $comment_id)) %>" | ||
| hx-confirm="Do you really want to delete the comment written by <%= $user->name %>?" | ||
| hx-target="closest .comment-row, .pinned-comment-row" | ||
| hx-swap="outerHTML" |
There was a problem hiding this comment.
I don't think we want to replace the target element with the response. We want to delete the target element - but of course only if the response was a 200 return code. We also need to decrement the number of comments shown in the tab header (if the comment is part of the test details page).
I guess you've chosen a good example here. That is the case kind of simple case we might be able to use htmx for. However, if it turns out that even this simple case it too complicated we know that we probably don't want to use htmx.
| //function deleteComment(deleteButton) { | ||
| // const author = deleteButton.dataset.author; | ||
| // if (!window.confirm('Do you really want to delete the comment written by ' + author + '?')) { | ||
| // return; | ||
| // } | ||
| // $.ajax({ | ||
| // url: deleteButton.dataset.deleteUrl, | ||
| // method: 'DELETE', | ||
| // success: () => { | ||
| // $(deleteButton).parents('.comment-row, .pinned-comment-row').remove(); | ||
| // updateNumerOfComments(); | ||
| // }, | ||
| // error: showXhrError.bind(undefined, "The comment couldn't be deleted: ") | ||
| // }); | ||
| //} |
There was a problem hiding this comment.
Feel free to delete the code completely. This way the diff statistics tell use how many lines of custom code we avoided.
| @@ -7,7 +7,7 @@ use Test::Most; | |||
| use FindBin; | |||
| use lib "$FindBin::Bin/lib", "$FindBin::Bin/../external/os-autoinst-common/lib"; | |||
| require OpenQA::Test::Database; | |||
| use OpenQA::Test::TimeLimit '5'; | |||
| use OpenQA::Test::TimeLimit '25'; | |||
There was a problem hiding this comment.
As you bumped the timeout without any other changes it might be worth checking if/why the test is slow for you. Generally it should work unmodified
Related: https://progress.opensuse.org/issues/156055
Draft PR