Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add clear Add comments button label to make it discoverable #5908

Closed
wants to merge 1 commit into from

Conversation

kalikiana
Copy link
Member

Also mention that this adds comments to all jobs.

image

Also mention that this adds comments to all jobs.
Copy link

github-actions bot commented Sep 3, 2024

Great PR! Please pay attention to the following items before merging:

Files matching assets/stylesheets/**:

  • Consider providing screenshots in a PR comment to show the difference visually

This is an automatically generated QA checklist based on modified files.

Copy link

codecov bot commented Sep 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.72%. Comparing base (a013d38) to head (56eea67).
Report is 220 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5908   +/-   ##
=======================================
  Coverage   98.72%   98.72%           
=======================================
  Files         394      394           
  Lines       38693    38693           
=======================================
+ Hits        38198    38201    +3     
+ Misses        495      492    -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@okurz
Copy link
Member

okurz commented Sep 9, 2024

Your commit message starts with "Add clear Add comments ..."?

Copy link
Contributor

@Martchus Martchus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I find this feature has the right amount of discoverability as-is. Considering it is an advanced feature that should be used with care it make sense to use an icon-only button in my opinion (and that's also why I initially designed it this way).

@okurz
Copy link
Member

okurz commented Sep 10, 2024

We might want to reconsider the design anyway with https://progress.opensuse.org/issues/166556. Maybe you want to incorporate that into your ideas?

@kalikiana
Copy link
Member Author

I find this feature has the right amount of discoverability as-is. Considering it is an advanced feature that should be used with care it make sense to use an icon-only button in my opinion (and that's also why I initially designed it this way).

See https://suse.slack.com/archives/C02CANHLANP/p1724915110449239?thread_ts=1724833412.133459&cid=C02CANHLANP for the original feedback suggesting people don't find the feature at all.

@kalikiana kalikiana closed this Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants