Unify perl linting rules #5348
Unify perl linting rules #5348
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5348 +/- ##
=======================================
Coverage 98.32% 98.32%
=======================================
Files 389 389
Lines 37319 37319
=======================================
Hits 36693 36693
Misses 626 626 ☔ View full report in Codecov by Sentry. |
josegomezr
force-pushed
the
experiment_unify_perl_lint_rules
branch
from
8811a7a
to
5b1d054
Compare
| -fbl # don't change blank lines | ||
| -fnl # don't remove new lines |
There was a problem hiding this comment.
I agree to include this line but I do not want to loosen the line-length rule. We must find a way to support project specific rule additions and exceptions.
There was a problem hiding this comment.
As I remember the conversation from the other PR there's no easy way to add exceptions per project. Could 120 be used instead?
There was a problem hiding this comment.
We already covered that we can not easily reduce os-autoinst-distri-opensuse from 160 down to 120
There was a problem hiding this comment.
Okay. I guess I'm fine with 160 then if it's the only deviation.
There was a problem hiding this comment.
I think we can live with a .perltidyrc per project. If the common project has a config, existing and new projects can use this by symlinking, but they don't have to, so openQA would keep its own config, if the common project uses 160, or if the common project uses 120, distri-opensuse would use its own.
That's at least what @josegomezr agreed on when we chatted today
josegomezr
changed the title
|
This pull request is now in conflicts. Could you fix it? 🙏 |
Testing the perltidy config from os-autoinst/os-autoinst-common#30