-
Notifications
You must be signed in to change notification settings - Fork 434
feat: document Google SCIM #2329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
vinckr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice! looks great already,
some minor style comments, but otherwise looks good to me.
I haven't tested this though.
One other thing to think about: there are quite a lot of screenshots in this doc - how can we make sure these are up to date? Ideally it would be automated, but in general it's an unsolved problem for the docs. Maybe @unatasha8 has an idea how we can keep screenshots up to date without much manual work.
otherwise looks good to me!
vinckr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm ![]()
Related Issue or Design Document
Checklist
If this pull request addresses a security vulnerability,
I confirm that I got approval (please contact [email protected]) from the maintainers to push the changes.
Further comments