Skip to content

chore: added docs for Apple to demonstrate usage of name scope #2235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

deepakprabhakara
Copy link
Contributor

@deepakprabhakara deepakprabhakara commented Jul 3, 2025

Related Issue or Design Document

Checklist

  • I have read the contributing guidelines and signed the CLA.
  • I have referenced an issue containing the design document if my change introduces a new feature.
  • I have read the security policy.
  • I confirm that this pull request does not address a security vulnerability.
    If this pull request addresses a security vulnerability,
    I confirm that I got approval (please contact [email protected]) from the maintainers to push the changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added the necessary documentation within the code base (if appropriate).

Further comments

@deepakprabhakara
Copy link
Contributor Author

@pi1814 to verify the scope and claims mapping is correct.

Comment on lines +91 to +92
[if 'given_name' in claims then 'firstName' else null]: claims.given_name,
[if 'last_name' in claims then 'lastName' else null]: claims.last_name,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This only works if the identity schema accepts "firstName", which the default (preset://email) doesn't, maybe we need to make that clear here? E.g. with multiple tabs?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aah yes good point.

@deepakprabhakara deepakprabhakara marked this pull request as draft July 4, 2025 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants