Skip to content

fix: unified reg #2118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 4, 2025
Merged

fix: unified reg #2118

merged 2 commits into from
Jun 4, 2025

Conversation

vinckr
Copy link
Member

@vinckr vinckr commented Apr 16, 2025 •
edited
Loading

closes #2115

Related Issue or Design Document

Checklist

  • I have read the contributing guidelines and signed the CLA.
  • I have referenced an issue containing the design document if my change introduces a new feature.
  • I have read the security policy.
  • I confirm that this pull request does not address a security vulnerability.
    If this pull request addresses a security vulnerability,
    I confirm that I got approval (please contact [email protected]) from the maintainers to push the changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added the necessary documentation within the code base (if appropriate).

Further comments

@vinckr vinckr marked this pull request as ready for review June 3, 2025 13:44
@vinckr vinckr force-pushed the vinckr/docs-janitor-0017 branch from c17beb1 to da5542b Compare June 3, 2025 13:45
aeneasr
aeneasr reviewed Jun 4, 2025
View reviewed changes
Copy link
Member

@aeneasr aeneasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should move to "Unified" and "profile-first" registration because it also matches naming of "unified" and "identifier-first" login

@vinckr vinckr requested a review from aeneasr June 4, 2025 09:36
@vinckr vinckr merged commit bfe58f1 into master Jun 4, 2025
8 checks passed
@vinckr vinckr deleted the vinckr/docs-janitor-0017 branch June 4, 2025 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aeneasr aeneasr aeneasr approved these changes

@zepatrik zepatrik Awaiting requested review from zepatrik zepatrik is a code owner

@piotrmsc piotrmsc Awaiting requested review from piotrmsc piotrmsc is a code owner

Assignees

@vinckr vinckr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

UI drift
2 participants
@vinckr @aeneasr