Skip to content

Conversation

@christiannwamba
Copy link
Contributor

Related Issue or Design Document

Checklist

  • I have read the contributing guidelines and signed the CLA.
  • I have referenced an issue containing the design document if my change introduces a new feature.
  • I have read the security policy.
  • I confirm that this pull request does not address a security vulnerability.
    If this pull request addresses a security vulnerability,
    I confirm that I got approval (please contact [email protected]) from the maintainers to push the changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added the necessary documentation within the code base (if appropriate).

Further comments

@aeneasr
Copy link
Member

aeneasr commented Apr 4, 2025

You can re-trigger the CI by clicking on the failing task. In cases like this where set up fails on install, it's probably some flake issue. I did it for you in this case

aeneasr
aeneasr previously requested changes Apr 7, 2025
@vinckr vinckr marked this pull request as draft April 17, 2025 15:14
@vinckr
Copy link
Member

vinckr commented Apr 17, 2025

missing the "Make authenticated requests to your API" part in the text - its there in the code examples we just need to assume the user is starting from scratch and also add it to the text!

Copy link
Member

@vinckr vinckr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

besides the new next.js quickstart I also went over the structure of the other quickstarts to make sure they all have the same order and structure. this is now more or less the case, some (e.g. react native) are still very different due to the nature of the quickstart.

@vinckr vinckr enabled auto-merge (squash) June 4, 2025 16:05
@vinckr vinckr merged commit 12e3057 into master Jun 4, 2025
9 checks passed
@vinckr vinckr deleted the update-nextjs-quickstart branch June 4, 2025 16:06
@aeneasr
Copy link
Member

aeneasr commented Jun 4, 2025

epic, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants