412 download all proposals from a cycle, with investigators removed. #417
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gly got a erro about using invalid hook call at moment
…od. the pdf doesnt contain any data. bad. the json file for the proposal also doesnt exist, and yet the optical file is correct and complete! oh and no supporting docs. so 1 of the 4 works. yet this code is the same code from the original extraction. so whats going on?
…od. the pdf doesnt contain any data. bad. the json file for the proposal also doesnt exist, and yet the optical file is correct and complete! oh and no supporting docs. so 1 of the 4 works. yet this code is the same code from the original extraction. so whats going on?
…ators. alas not working yet.
…le targets makes it no longer a optical observation for some reason
…e basic export now. i hope
…ly extracted and chekced before using. noted that export fails in radio mode as the tehcncialjusfications are being loaded. *sigh*
…ngle propsaol downloader and renderer. so that the editor doesnt now need to import manager code. manager code is only needed to call editor for the single.
…overview not being generated with the export renderer.
…n a reasonable way. aka, sneding a notificiation if for some reason, we get to a place where a user presses a button that hasnt got its mutation function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ties in a request from Dan to be able to download all proposals for a given cycle. The caveat here is that we need to remove investigators as well as a inner zip process.
part of the issues found is that since download has been made, the tables on the overview page have changed to accordions which by default don't show all the details. So this pr, on top of the actual code to make the nested zip, has had to figure a way to expand those accordions by default when making the pdf.
This work should likely be pushed to the default export functionality once figured out fully.