396 / 376 / 347 / 358 / 409 / 357 / 400 / 411 contains all the changes for optical that currently stands. #398
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gure the complex bit about actual selections.
… occured already. still missing the text box, and still got this weird insutrmant past value lingering
…do the resolve step by step. at moment. removed the need for the params for proposal id and observation id. behaviour still works. but no reaction to save button
…, so we need to override its. there doesnt seem to be a react way to add a onchange call to fields. which seems off compared to angular. it seems theres still issues. something about unique keys.
…g. but thats not working yet. and trying to diagnose why text isnt working correctly.
…t of form elements. pushing this so that i can explore that
…ckbox and then lock down single lists.
…roposal tool components file. mock will fail drastically now.
… now work as well.
…using data objects instead of raw maps. but for the time being works. and race conditions killed.
…-html # Conflicts: # src/main/webui/src/ProposalEditorView/observations/edit.group.tsx # src/main/webui/src/generated/proposalToolComponents.ts
…argets 265 be able to upload a list of targets
…n-messages 345 proposal submission validation messages
…like its working) doest seem to allow the new proposals to appear. weirdly. the optical database is updating with data, so that part is working.
…olved a number of warnings / errors that were in the file as well.
…-export # Conflicts: # src/main/webui/src/generated/proposalToolContext.ts
356 abs optical import export
…cal-submission # Conflicts: # src/main/webui/src/ProposalEditorView/submitProposal/ValidationOverview.tsx
409 abs nights vs hours
adds support for optical submission support. by design this also fixed #394
400 abs optical UI overview table
alan-stokes
changed the title
411 ob mode master update
Contributor
Author
|
it seems there are issues with master not passing its own tests as these issues: https://github.com/orppst/pst-gui/actions/runs/15016994285/job/42197154156 are not related to the work in the pr. |
alan-stokes
changed the title
411 abs removes submission mode from the optical submission page.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
347:
contained the basic UI for a optical observation, utilizing the xml data from the API .
358:
this adds functionality to remove optical data when dealing with an observation or proposal.
376:
this pr when finished will allow users to have optical and radio observations separately.
at moment. we're now splitting the observation page into 2 separate pages and have the observation table page display 2 tables. one for optical and one for radio. I had tried making a popup which would allow us to have 1 add button, but the lack of a "optical, radio, cancel" format in mantine modals meant having to engineer a new one and it seemed easier to present two tables at that point.
396
brings in the polaris mode and removes the technical goals option from the list when in optical mode. and then hides the correct table from observations when in either optical, or radio, and adds a header for when in both to distinguish between them. It also changes the command for new proposals without targets and technical goals to reflect if they need a technical goal or not.
409
added code to call the rest api for the telescope timing data and then using it within the overview summary code to calculate hours.
it also includes a number of fixes to importing proposals which were found during a demo. Now the investigators of imported proposals are checked and if the current user doesnt exist in the list, it is added. any other missing users are removed as well. includes a fix to the export as well so that the optical files are ensured to exist. as a export failed randomly and so we found a race condition which needed shutting down
357
this covers functionality to support a optical submission. manly adding new checks for optical, ensuring the validation respects the mode. and adding clone functionality.
I did try to have them embedded in one transaction in the backend. but it seems we haven't configured the system to support multiple database transactions and all my attempts to do so meet with failure. so i walked back to 2 separate calls which does work. but does open up the well known risk of desync between the databases.
have added the clone functionality to the proposal clone as well.
400
adds a telescope summary accordion in the overview page.
411
removes the observation modes from the submission page when in optical mode.
it also includes a quick fix for the maths for hours vs nights.