396 / 376 / 347 / 358 / 409 / 357 / 400 / 411: contains all the changes for optical that currently stands #86
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e repo, but it stops working due to my ssh key expiring, which made me then realise its not even part of our repos anymore (head shake) so putting them here until i figure out what the right place is.
…is works. we need to find a better way to fix the enviromental variable
…ent repos.this time the master brnach on telescope config data doesnt exist. its called main. likely a change from long ago. when peeps wanted to move away from master and slave inconitations.
This was referenced Apr 15, 2025
…s-read-from-file-upload 78 ability to add a list of targets read from file upload
…plit them up. and then extra work to try to get the summary page to be filled in
…d the enum for better usage
…ble than having them in the same call. but at least its a step forward
…cal-submission # Conflicts: # src/main/java/org/orph2020/pst/apiimpl/rest/ProposalResource.java
…gator 72 imported proposal wrong investigator
409 abs nights vs hours
357 abs optical submission
400 abs optical UI overview table
alan-stokes
changed the title
…OURS # Conflicts: # src/main/java/org/orph2020/pst/apiimpl/rest/ProposalResource.java
411 ob mode master update
409 rest request malformed
alan-stokes
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for ticket 376:
adds new rest apis and modifys old ones to reflect the need for just a proposal id interface.
adds the ability to extract the telescope name and instrument name for a set of observations (aka the optical ones from a proposal) and a list of observation ids which are the ones which contain optical data in the first place.
for ticket 358:
this pr adds delete functionality of the optical telescope data.
for ticket 347:
contains the basics for a optical interface. it contains a second database that builds a store based off data objects inside pst-lib. It also provides a rest interface for different elements from the optical telescope.
the list of names of different telescopes.
the UI elements for the different telescopes.
saving a observations telescope specific data items.
extracting an observation telescope specific data items.
it also includes the xml reader for the xml files describing the telescope ui requirements. This includes code that removes some of the more offending issues with xml entries, which breaks the UI code hard. such as select boxes with no elements. oh. it also includes fixes to the github actions to utilise same name branches from dependent repos. a typical process for multi repo works. That stuff could be extracted as its own pr if you truly want.
for ticket 396:
contains logic to hold a mode parameter which is extracted from the environmental variables. it allows the Polaris system to adapt to which "mode its currently running in. either, optical, radio, or both." it has a get and set rest api, the set mainly to help in debugging in a more efficient manner than changing the environmental variable and then rebooting the whole back-end. We might want to lock that rest request out in production, or have a password protection or something to ensure its only used as needed.
for ticket 409:
this adds support to the telescope xmls to include a relationship between nights and hours. this means the xml reader has now extracted the value from the xml, so new schema changes, and then those values are handed over by a rest api for the gui.
on top of this, there are fixs for submission which were found during the testing. specifically, that when the backend is rebooted. there is no standing relationship for user ids. so when a proposal is imported. the investigators are basically all suspect. including the pi, which if not adjusted to the current importer, can result it being imported, but not to the active user. There is also issues with new users which don't have orcid ids which causing the import to fail, as well as issues with organisations with partial data. This pr includes fixing the investigators to include the user as PI, and to filter out other investigators which dont exist in the current polaris setup.
for ticket 357:
adds the logic to respect modes in the submission validation. it also cleans up the usage of mode enum, having realized id screwed it up before. There may be residual floating changes trying to make the transactional thing work.
for ticket 400:
covers changes from 396 to 400. I think this basically boils down to a master merge. but not sure.
for ticket 411
nothing needed for that ticket. all GUI related.