Skip to content

Conversation

@alan-stokes
Copy link
Contributor

this draft pr is holding point for all the xml reader work on the optical telescopes.

the xml reader itself is working. it no longer absorbs everything either. If the xml has commented out bits at the top level, the reader will respect that and not absorb the data associated with the commented out instruments. It will produce a mass of warnings about these issues. which we could clean up if we felt we had the time.

next is to tie it into the api and databases.

…e repo, but it stops working due to my ssh key expiring, which made me then realise its not even part of our repos anymore (head shake) so putting them here until i figure out what the right place is.
@alan-stokes alan-stokes added the core functionality A requirement of the tool label Feb 18, 2025
@alan-stokes alan-stokes self-assigned this Feb 18, 2025
@github-actions
Copy link

github-actions bot commented Feb 18, 2025

Test Results

47 tests  +12   47 ✅ +12   9s ⏱️ -1s
13 suites + 1    0 💤 ± 0 
13 files   + 1    0 ❌ ± 0 

Results for commit c483c32. ± Comparison against base commit 90fecea.

♻️ This comment has been updated with latest results.

…ent repos.this time the master brnach on telescope config data doesnt exist. its called main. likely a change from long ago. when peeps wanted to move away from master and slave inconitations.
@alan-stokes alan-stokes marked this pull request as ready for review March 31, 2025 08:42
@alan-stokes
Copy link
Contributor Author

this branch, when used in conjunction with:
orppst/pst-gui#368 and orppst/pst-lib#8

contains the basics for a optical interface. it contains a second database that builds a store based off data objects inside pst-lib. It also provides a rest interface for different elements from the optical telescope.

  1. the list of names of different telescopes.
  2. the UI elements for the different telescopes.
  3. saving a observations telescope specific data items.
  4. extracting an observation telescope specific data items.

it also includes the xml reader for the xml files describing the telescope ui requirements. This includes code that removes some of the more offending issues with xml entries, which breaks the UI code hard. such as select boxes with no elements.

@alan-stokes
Copy link
Contributor Author

oh. it also includes fixes to the github actions to utilise same name branches from dependent repos. a typical process for multi repo works. That stuff could be extracted as its own pr if you truly want.

@pahjbo pahjbo changed the base branch from master to optical April 11, 2025 16:32
@alan-stokes
Copy link
Contributor Author

being shut down in favor of the all encompassing pr #86

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core functionality A requirement of the tool

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants