Skip to content

chore: 🔧 modify All Fields return type#1445

Merged
collerek merged 2 commits intoormar-orm:masterfrom
Sube-py:master
Apr 1, 2025
Merged

chore: 🔧 modify All Fields return type#1445
collerek merged 2 commits intoormar-orm:masterfrom
Sube-py:master

Conversation

@Sube-py
Copy link
Contributor

@Sube-py Sube-py commented Mar 20, 2025

For IDE type hints, e.g. str type, you can hint both splits and functions on String.

@codecov
Copy link

codecov bot commented Apr 1, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (8c22fcb) to head (95761cf).
Report is 2 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##            master     #1445   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          207       207           
  Lines        14942     14944    +2     
=========================================
+ Hits         14942     14944    +2     
Files with missing lines Coverage Δ
ormar/fields/model_fields.py 100.00% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@codspeed-hq
Copy link

codspeed-hq bot commented Apr 1, 2025

CodSpeed Performance Report

Merging #1445 will improve performances by 12.38%

Comparing Sube-py:master (95761cf) with master (8c22fcb)

Summary

⚡ 1 improvements
✅ 83 untouched benchmarks

Benchmarks breakdown

Benchmark BASE HEAD Change
test_count[250] 3.6 ms 3.2 ms +12.38%

Copy link
Collaborator

@collerek collerek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks!

@collerek collerek merged commit 62da098 into ormar-orm:master Apr 1, 2025
21 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants