Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use binary units for size instead of decimal units #177

Merged
merged 1 commit into from
Dec 7, 2024

Conversation

Integral-Tech
Copy link
Contributor

Description

  • Use binary units for size instead of decimal units

Motivation and Context

  • In Linux, binary units are used by default instead of decimal units. For example, ls -h shows file sizes in abbreviation (K, M, G, T), which represents KiB, MiB, GiB, TiB respectively instead of KB, MB, GB, TB.

How Has This Been Tested?

Screenshots / Output (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (no code change)
  • Refactor (refactoring production code)
  • Other

Checklist:

  • My code follows the code style of this project.
  • I have updated the documentation and changelog accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • Rustfmt and Rust-clippy passed.

@Integral-Tech Integral-Tech requested a review from orhun as a code owner December 2, 2024 13:58
Copy link
Owner

@orhun orhun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@orhun orhun merged commit d3b5423 into orhun:master Dec 7, 2024
3 of 5 checks passed
@Integral-Tech Integral-Tech deleted the use-binary-units branch December 7, 2024 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants