Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(static): make symbols sortable by name or address #99

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

XXMA16
Copy link
Contributor

@XXMA16 XXMA16 commented Nov 10, 2024

Description of change

Made the Symbols from Static Analysis sortable by name and address. The sorting modes can be cycled with S.

Concerns

Should I make a Sort trait in order to have less repeated code?
Should info_index be bound to Static Analysis instead of State?
The option to sort is shown for Dynamic and Relocations too, even though it doesn't do anything.

partially closes #22

@XXMA16 XXMA16 requested a review from orhun as a code owner November 10, 2024 15:39
Copy link

codecov bot commented Nov 10, 2024

Codecov Report

Attention: Patch coverage is 0% with 58 lines in your changes missing coverage. Please review.

Project coverage is 3.25%. Comparing base (09137d2) to head (311261d).

Files with missing lines Patch % Lines
src/elf/symbols.rs 0.00% 49 Missing ⚠️
src/tui/state.rs 0.00% 8 Missing ⚠️
src/tui/command.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##            main     #99      +/-   ##
========================================
- Coverage   3.30%   3.25%   -0.04%     
========================================
  Files         19      19              
  Lines       2426    2462      +36     
========================================
  Hits          80      80              
- Misses      2346    2382      +36     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@orhun
Copy link
Owner

orhun commented Nov 13, 2024

Looks good to me! Thanks for implementing! <3

Can we also use lowercase s for the sort?

Should I make a Sort trait in order to have less repeated code?

Sounds good. I'm curious how a trait would look like though. What is in your mind?

Should info_index be bound to Static Analysis instead of State?

Yup, sounds good. Feel free to make the refactor.

The option to sort is shown for Dynamic and Relocations too, even though it doesn't do anything.

Would be nice to disable that somehow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sort Symbols by Name or Address
2 participants