-
-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TD with query() that exposes builder #38
Conversation
Hi @bilogic. Please note that tests fail |
ohh.. ok thanks, let me check why. |
Can I help you with something so that we can integrate this? |
Yes of course, sorry I have been busy. |
Ok, I believe I got it fixed. Just some feedback below:
Thank you! |
@tabuna anything else i need to do? Thanks. |
@bilogic Hi. I have local holidays now. I will be back in a couple of days and combine this |
@tabuna got it! enjoy! Thanks! |
Hi, Does this need more changes? |
@tabuna can we merge this? |
@tabuna sorry, can we also make a decision on this? otherwise I have quite a bit of code hanging in the air. Thank you. |
Hi, I would like the code that affects the builder to be in the TD class, but I don't have enough time to change it myself. It would be great if you take it on yourself. |
Ok, I think I get what you mean, but if I'm going to move the logic into TD class, would it be better to move into https://github.com/orchidsoftware/platform's TD? |
According to the idea, there should be a hook/event that we will define in TD (from crud) |
Hi,
Referencing #36, I added sort as well. Let me know if any other changes required. Thank you.