Repository navigation
Speed up assistant reads for leaf document sources - #250
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Assistant profiles and chat lists repeatedly initialized the full source graph for documents without dependency edges. Check current document access first, then return the one-node result when the canonical document-edge set is empty. Documents with dependencies continue through the existing recursive guard.
A shared edge builder drives both traversal and the leaf check. Migration 306 replaces the generated function while preserving its signature, STABLE snapshot behavior, security-invoker mode and jit=off. Complete source/migration/installed-body parity and the unchanged historical general predicate are checked.
Validation: 87 focused provenance, scope, profile, origin, conversation, delivery and notification checks passed, including NULL arguments, membership/deletion/AI-off changes, edge addition/removal, retained entries and cycles. Backend build/types, formatting, source organization and diff checks passed; independent source review found no actionable issues.
Three alternating synthetic comparisons using 221 chats, 228 jobs, roughly 9,000 dependency edges and 181 documents preserved complete responses: profiles 13,707→1,574ms median; chat list 1,855→312ms. These are local measurements; production verification follows rollout through update.bat. Hosted CI is not awaited per maintainer instruction.