Repository navigation
Keep item editor actions inside the scroll viewport - #249
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The item editor's sticky action row used a negative bottom offset, allowing Save and Cancel to extend below the modal's clipped scroll viewport on a phone. Pin the row at the viewport edge so the complete controls stay visible.
Validation: live 390×844 inspection showed action bottoms extending past the modal bottom; desktop build, scoped formatting and diff checks passed. The final production update will recheck complete buttons, selectors and cancellation. No task was submitted during inspection. Hosted CI is not awaited per maintainer instruction.