Repository navigation
Stabilize scheduled Agenda worker-loss recovery test - #226
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stabilize the existing scheduled-Agenda worker-loss regression uncovered by main CI while qualifying #222/#223.
The test ran a live worker while expiring its lease, then assumed
claimScheduledAgenda(id) === nullguaranteed completed recovery. The claim intentionally usesFOR UPDATE SKIP LOCKED: null can also mean the live provider poll briefly holds the row lock. The test then raced the still-running worker and readrunningrather thanfailed.Model the lost worker using the same real queued-envelope setup already used by the neighboring recovery test. No live polling loop survives the simulated loss. Explicitly hold the row lock to prove a null claim leaves the run running; after releasing it, assert completion_unknown failure, rejection of the late signed reply and exactly one model operation. Extract the existing envelope fixture for reuse.
Evidence
Prepared in an isolated checkout from main. Full CI will qualify the resulting main revision.